Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert/dollar sign flood #814

Merged
merged 18 commits into from
Jan 15, 2024
Merged

Revert/dollar sign flood #814

merged 18 commits into from
Jan 15, 2024

Conversation

swissiety
Copy link
Collaborator

closes #813

@swissiety swissiety requested a review from JonasKlauke January 11, 2024 20:57
@swissiety swissiety marked this pull request as ready for review January 11, 2024 21:00
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cdd5e0a) 63.70% compared to head (a20cf3a) 63.69%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #814      +/-   ##
=============================================
- Coverage      63.70%   63.69%   -0.01%     
+ Complexity      3439     3434       -5     
=============================================
  Files            313      313              
  Lines          15163    15146      -17     
  Branches        2568     2565       -3     
=============================================
- Hits            9660     9648      -12     
+ Misses          4597     4594       -3     
+ Partials         906      904       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swissiety swissiety requested a review from stschott January 11, 2024 21:19
Copy link
Contributor

You updated the documentation - Doc Preview.

@kadirayk kadirayk merged commit f471853 into develop Jan 15, 2024
10 checks passed
@swissiety swissiety deleted the revert/dollarSignFlood branch February 8, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert dollar sign for locals
2 participants