Reenable previously broken test #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, forgot to push that
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #878 +/- ##
=============================================
+ Coverage 68.26% 68.51% +0.25%
- Complexity 3877 3884 +7
=============================================
Files 311 311
Lines 15186 15186
Branches 2587 2587
=============================================
+ Hits 10366 10405 +39
+ Misses 3911 3878 -33
+ Partials 909 903 -6 ☔ View full report in Codecov by Sentry. |
stschott
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates dex2jar to the newest version available and reenabled the previously broken Soot-1577 test (related: soot-oss/soot#1577).
After looking a bit into it I found that dex2jar was not the culprit, but rather something fixed in https://github.com/soot-oss/soot/pull/2047/files.
Anyway, I think that soot-oss/soot#1577 can be closed and this PR will enable the appropriate test for the underlying again here.