Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding FieldModifiersValidator and test cases #892

Merged
merged 11 commits into from
Mar 19, 2024
Merged

Conversation

akshitad11
Copy link
Collaborator

Adding FieldModifiersValidator and test cases

@akshitad11 akshitad11 requested a review from kadirayk March 13, 2024 21:55
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 69.99%. Comparing base (ea1b4c9) to head (232bf8d).

Files Patch % Lines
...ootup/core/validation/FieldModifiersValidator.java 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #892      +/-   ##
=============================================
+ Coverage      69.97%   69.99%   +0.02%     
- Complexity      4049     4061      +12     
=============================================
  Files            310      311       +1     
  Lines          15258    15276      +18     
  Branches        2606     2611       +5     
=============================================
+ Hits           10677    10693      +16     
  Misses          3726     3726              
- Partials         855      857       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stschott stschott merged commit a39894d into develop Mar 19, 2024
9 checks passed
@stschott stschott deleted the FieldValidatorChanges branch March 19, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants