-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
formatting: use emoji
2.0 style
#119
Conversation
Indeed, it is straightforward to do it this way. I suggest updating the README to document that Commit message example:
(We do obey the 72-character wrapping rule, except for URLs, because we want them to stay clickable.) |
Hey! |
No big rush! As I said before, the workaround is easy (downgrade to |
There we go. Updated the commit message. |
Readme update? |
Crap. I knew there was something I missed. 😂 |
Alrighty. What about this? |
Rather than add a new section, I was expecting an update to the existing mention here: Lines 47 to 49 in 588db54
And if you want to give an install command with Realistically though, I wouldn't worry too much about getting the readme perfect. That feature really should be a setuptools extra, with the requirement specified in package metadata. This is largely why I had in mind a minimal update to the existing mention of using the |
OK, we're getting there! Update README again. |
The `use_aliases` argument was deprecated in `emoji` 1.7 and removed in 2.0. It was replaced with the option `language='alias'`. Update README.md to reflect this requirement. Fixes sopel-irc#118. See also: https://github.com/carpedm20/emoji/blob/d8bbfe455c6fcd12b96ed1dce6e0978fe7a47431/emoji/core.py#L95-L98
Seems, I missed to amed the commit :-( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gotta think about a release plan for this, the setuptools extra, and the other bug fixes I'm working on—but your part is all done. Thanks!
Thanks a lot @dgw ! Esp. for your patience to get this done. |
use language='alias' instead of use_aliases=True, which was deprecated in 1.7.0,
see also: https://github.com/carpedm20/emoji/blob/v1.7.0/emoji/core.py
Pretty straight forward change. Let me know if there is anything else that I can/should do, since I already have the fork open.