Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: send API version header #122

Merged
merged 1 commit into from
Apr 4, 2023
Merged

github: send API version header #122

merged 1 commit into from
Apr 4, 2023

Conversation

dgw
Copy link
Member

@dgw dgw commented Mar 31, 2023

https://docs.github.com/en/rest/overview/api-versions#about-api-versioning

This is for future-proofing. Occasionally the plugin's been broken by API changes that we weren't prepared for (I, at least, am not very good about keeping on top of announcements), and this way we are explicitly declaring which version we want and gaining a 24-month grace period to adapt after a new version is released.

@dgw dgw added the tweak label Mar 31, 2023
@dgw dgw added this to the 0.5.0 milestone Mar 31, 2023
@dgw dgw merged commit 4987fa1 into master Apr 4, 2023
@dgw dgw deleted the gh-api-versioning branch April 4, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant