Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: add config & logic to skip too-short inline issue numbers #137

Merged
merged 1 commit into from
May 12, 2024

Conversation

dgw
Copy link
Member

@dgw dgw commented May 2, 2024

Resolve #131, including a new config setting to override the mitigation if so desired.

The new config value is intentionally omitted from configure(), since for most users the default will be fine and it would be more confusing to try to explain the setting's purpose in a one-line prompt.

As it says in #131, a per-channel option might be helpful in the long term. But like I wrote in #136, more granular/nuanced controls for things will be easier to do after the plugin is de-spaghettified (long overdue work).

The new config value is intentionally omitted from `configure()`, since
for most users the default will be fine and it would be more confusing
to try to explain the setting's purpose in a one-line prompt.
@dgw dgw added the enhancement label May 2, 2024
@dgw dgw added this to the 0.5.0 milestone May 2, 2024
@dgw dgw merged commit 6eaae5f into master May 12, 2024
@dgw dgw deleted the short-inline-number-config branch May 12, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to ignore short unprefixed inline issue numbers
1 participant