Replace SopelMemory.contains() with in operator
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the method has been deprecated for ages (since Willie 4?), it was only just recently "officially" marked as such in Sopel's master branch. Since using it after Sopel 7 comes out will produce a deprecation warning in Sopel's output, we should replace it.
dgw
added a commit
that referenced
this pull request
Apr 27, 2019
Prevents deprecation warnings on Sopel running from latest source: origin/deprecated-SopelMemory.contains (#33) Handles GitHub's beta "draft" pull requests feature: origin/webhook-draft-prs (no PR open yet)
|
Oh hell, just push this out with 0.1.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the method has been deprecated for ages (since Willie 4?), it was only just recently "officially" marked as such in Sopel's master branch. Since using it after Sopel 7 comes out will produce a deprecation warning in Sopel's output, we should replace it.
This isn't super urgent, as this plugin's next (non-patch) version will drop long before Sopel 7 is ready, but having it all set to merge is the goal here.