Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook: Handle milestone add/remove for issues/PRs #35

Merged
merged 2 commits into from
Aug 4, 2019

Conversation

dgw
Copy link
Member

@dgw dgw commented May 10, 2019

Uses helper functions added in #23, so that PR must be merged first.

@dgw dgw added this to the 0.2.0 milestone May 10, 2019
@dgw
Copy link
Member Author

dgw commented May 12, 2019

This only handles adds correctly, at present. Milestone removals do not include enough information to print the same kind of message; see GitHub Community thread.

dgw added 2 commits August 4, 2019 01:57
Depends on helper functions added in #23.
GitHub doesn't send it, so it's currently impossible to display which
milestone was removed.
@dgw dgw force-pushed the webhook-issue-pr-milestones branch from 6867e93 to ced9a00 Compare August 4, 2019 06:57
@dgw
Copy link
Member Author

dgw commented Aug 4, 2019

Whitespace fail fixed.

@dgw dgw merged commit fa82a47 into master Aug 4, 2019
@dgw dgw deleted the webhook-issue-pr-milestones branch August 4, 2019 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant