Fix repo URLs not being detected mid-line #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change became an[other] overhaul of how the URL patterns get built. It sure felt good to eliminate the repeated `.format()` calls! Tested all three URL types (if `issuecomment`s are counted distinct from regular issue links, four). No changes to the existing behavior except that repo links are correctly detected where they previously were not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change became an[other] overhaul of how the URL patterns get built. It sure felt good to eliminate the repeated
.format()calls!Tested all three URL types (if
issuecomments are counted distinct from regular issue links, four). No changes to the existing behavior except that repo links are correctly detected where they previously were not. (Glad I caught the bug almost introduced, which would have seen double output from detecting repo URLs inside the other types.)Also renamed the
data_url()function torepo_info(), so its name actually means something.