Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formatting: extra whitespace != truncated comment #50

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

dgw
Copy link
Member

@dgw dgw commented Nov 14, 2019

A one-line comment with extra surrounding whitespace would trigger adding […] to the "shortened" comment even if the line wasn't truncated. That's wrong.

@dgw dgw added the bugfix label Nov 14, 2019
@dgw dgw added this to the 0.2.4 milestone Nov 14, 2019
@dgw dgw changed the title formatting: trailing whitespace != truncated comment formatting: extra whitespace != truncated comment Nov 14, 2019
@dgw dgw force-pushed the comment-trailing-space branch from 4121cde to 9acdf3b Compare November 14, 2019 17:01
@dgw dgw merged commit 4a30838 into master Dec 3, 2019
@dgw dgw deleted the comment-trailing-space branch December 3, 2019 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant