webhook: Handle issue transfers #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub doesn't include the user who initiated the transfer in webhook payloads, unfortunately, even though it adds a "transferred" event to the timeline once completed. (That "transferred" event doesn't appear to be sent on its own, either, unless it's attached to some category other than "Issues" for some reason.)
A bit more straightforward, these, since they have their own distinct "action" value. No need to sniff for dict keys and guess like for incoming transfers. (Also helpful: the "sender" is who transferred it, not who created the issue.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I dislike using the presence of certain dict keys to guess whether an issue was natively created vs. transferred in, but GitHub ties my hands on that. There's also no workaround for determining who actually transferred the incoming issue; that data just isn't included.
At least issues transferred out have a distinct "action" type and proper "sender" info, thankfully…
[As an aside: The more features that get added to the webhook handler here, the more obvious it is that GitHub's webhook payloads are not very well thought-out in places, especially when newer site features from the last few years are involved.]