Capitalize GitHub everywhere it makes sense to do so #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Officially the name of the site is "GitHub", not "Github". In filenames, URLs, and so on, it makes sense to have this be lowercase, but the name of the site shouldn't be output to users without the capital H. Also changed the internal name of the config section, but that won't affect existing users.
|
Should have touched the readme in this PR, whoops. I'll get around to updating it next time I get bored with actual code, maybe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Officially the name of the site is "GitHub", not "Github". In filenames, URLs, and so on, it makes sense to have this be lowercase, but the name of the site shouldn't be output to users without the capital H.
Also changed the internal name of the config section, but that won't affect existing users.
(Running through this find-and-replace really gave me the idea that Sopel needs a way for modules to just declare that all their output should have a given prefix. So many repetitions of
[GitHub]!)