youtube: update error handling #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bonus: At some point the `apiclient` import name is going to vanish, so I just switched to the long-available primary name `googleapiclient` instead. (Our required version range starts well after when the new name was added.)
dgw
force-pushed
the
silence-api-url-on-error
branch
from
a708ec3 to
1503187
Compare
|
Successfully tested both setup phase and runtime phase, even though I'm not sure how one would get past setup and into runtime if the API key isn't valid. But if someone somehow does, the code will handle it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll test this sometime tomorrow, I hope (never know if I'll have time for literally anything on Thursdays, but that's my goal). Or, since this is meant to fix #22, maybe @cottongin will get to it first. I'd love verification from the original issue reporter anyway!
Bonus: At some point the
apiclientimport name is going to vanish, so I just switched to the long-available primary namegoogleapiclientinstead. (Our required version range starts well after when the new name was added.)