Better live video support #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Split the upload-date ("publishedAt") "parse" function into two, one
that really *only* parses, and another that formats
* Request additional video details pertaining to live-stream status from
the YouTube API
* Conditionally output certain pieces of information depending on
whether the video is a scheduled or active live stream
* For example, view count is irrelevant for a "live" video, but it's
interesting to see how many people are currently watching
* An "upcoming" stream has no viewer info available (YT doesn't expose
the "waiting" count via the API, AFAICT), so the "views" info item
can be skipped for these
* Upload date, comments, and length/duration also adapt or skip
themselves depending on the video's live status
This patch contains Yet Another Reason why Sopel should make the
prepositions outputted by `tools.time.seconds_to_human()` optional.
Honestly, I can't remember ever writing code using that function
*without* needing to remove the ' ago' or 'in ' from its output.
dgw
force-pushed
the
live-stream-support
branch
from
5952752 to
52c7bca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drafted on top of #27, for the next feature release.