Add tests to verify handling of expected URL types #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shamelessly copied and adapted my own previous work on sopel-reddit. I'm not 100% convinced that handling `/watch?v=...&list=...` is covered in the least-fragile way possible. The order in which Sopel matches callables isn't guaranteed to be stable or deterministic, so I really don't like checking match 0 against expected rule 0, etc.
With advice from Exirel, The One and Only (use sets, duh). Co-authored-by: Exirel <florian.strzelecki@gmail.com>
|
GitHub apparently does not, in fact, reevaluate the branch point from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is, verify e.g.
https://youtu.be/VIDEO_IDtriggers the video-info callable,/playlist?list=PLblahblahtriggers the playlist info callable, and so on. (There is no functional testing, only making sure that each URL type matches the right callable.)Based on #56, so it starts as a draft.
Pushing this will also force GH to reevaluate which commits are "new" after merging Handle
/live/VIDEO_IDlinks #56.