Sopel 7 notes #17
Merged
Sopel 7 notes #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And… Netlify doesn't build the merge result. Lame. |
6 tasks
10 tasks
dgw
force-pushed
the
sopel-7-notes
branch
2 times, most recently
from
2d86a2c to
fb3804b
Compare
|
Rebased. On the plus side, that means Netlify will build the preview more or less accurately. For now. |
|
Might have to rebase again to make sure the page-note from f8f6ada gets updated. Sopel 7 is soon to be released, and won't be in development any more at that point. Edit: Did it. Don't want to forget. |
Includes discussion of the first major change that is definitely going to be included: restructuring the CLI. This branch will be updated as deprecations and breaking changes are merged into Sopel's master branch, and probably squashed down for publication on the live site when we get near release.
Fixed a bit of wording, and renamed some headings
All subject to change, but still far better than having no plans at all. Motivated by merging PR 1488 into the main Sopel repo, which added warnings when run under Python 2.
See PR 1403 in the main Sopel repo, and issue 1200 there.
Includes "fix" for labeled link nearby, since indenting those right after a list has caused problems elsewhere on the site.
Just say "update your shit" once. No need to put it in every subsection.
`sopel-config` is already in master, and `sopel-plugins` will be merged soon. A couple extra deprecated CLI options to `sopel` were also worth mentioning here, per conversations on Sopel's issue tracker.
Now that the implementation is in place, some of the future-tense stuff here no longer made sense being written in future tense.
The new CLI layout has been updated, too. We're trying *really* hard to make it clear what's a "plugin" (add-on functionality) and what's a "module" (part of Sopel or its API, like `sopel.tools` & submodules).
Updated content of just about every page containing the string "module" to use "plugin" instead when appropriate. We're all-in on this change of terminology; even script filenames and variables are updated. Tweaked the plugin-autodoc script to use Python 3, as well. It was not working properly under py2 on my test system, and since Netlify's build images all have py3 available it makes more sense to just use that than spend time fixing the problem under 2.7 (which is EOL soon). Now the whole Netlify build script calls python3/pip3 specifically. Note: The plugin-autodoc script has a kludge to let upstream _sopel keep its references to the '_usage/meetbot-module.md' page even though it's been renamed to '_usage/meetbot-plugin.md'. At some point, that should be removed. The script needs plenty of other cleanup, too, so…
Those plugins were removed from core and made into separate packages.
|
Merging #10 caused a conflict in the tutorial. Fixed. |
Not sure what I was doing back in October with that extra PR. Keeping both of them would make merging a pain, so cherry-picking the extra updates from there keeps the main "Sopel 7" branch nice and clean.
We decided to require the `callback` in `bot.unregister_url_callback` too, very late in the cycle. Fortunately it didn't require rewriting a whole lot of documentation.
Sphinx is only one dependency required to build the docs. Better to just install everything. It doesn't take long to run a `pip install`. Also updates the _sopel submodule to a version that contains all the correct dependencies, including Sphinx, so this commit can be built.
The spellcheck plugin was moved out of core into its own PyPI package, meaning we don't need its dependencies any more.
A lot fewer old plugins will need to be updated now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged #13, and updating this branch to put the file in the right place therefore broke branch previews on Netlify (since the
_upgradingcollection isn't enabled in the branch's Jekyll config).I don't really want to rebase the branch, so here's hoping that Netlify's PR previews are like Travis's PR builds—i.e., that they build the merge result, not the source branch.