-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Independent generation of latest.json
file
#50
Conversation
9d350d6
to
8ff1379
Compare
Indeed, the first PR build did fail. But I have performed the fixups I needed to, rebased the branch, and now it works. To illustrate the patch a bit better, here is the old {
"version": "8.0.0",
"unstable": "8.0.0",
"release_notes": "https://sopel.chat/changelog/8.0.0/"
} And with this patch, that turns into: {
"version": "8.0.0",
"unstable": "8.0.0",
"release_notes": "https://sopel.chat/changelog/8.0.0/",
"unstable_notes": "https://github.com/sopel-irc/sopel/releases/v8.0.0"
} The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As expected I had a lot to say about this but none of it is a show-stopper. LGTM
One of the suggestions—the one to avoid The only downside to using {"version": "8.0.0", "unstable": "8.0.0", "release_notes": "https://sopel.chat/changelog/8.0.0/", "unstable_notes": "https://github.com/sopel-irc/sopel/releases/v8.0.0"} |
Passing |
Independent generation of `latest.json` file
Meant to be done as part of #50, but I *might* have forgotten to do that before hitting Merge. Oh well!
8b595b9
to
81876cf
Compare
Hmm, I did my pushes in the wrong order and confused the heck out of GitHub. All of the feedback here was folded into a squashed commit, 81876cf, and then merged to Thanks for the review @SnoopJ (and @Exirel, the silent partner on IRC) |
The script loads the most recent releases from PyPI now, instead of being part of the changelog script (since the changelog won't necessarily include dev builds, prereleases, etc.). The
unstable
version is no longer just an alias to the current stable version if there is a newer prerelease.Leans on
packaging.version
to do the heavy lifting (parsing version specifiers into sortableVersion
objects). Fortunately we already getpackaging
andrequests
for free when installing_sopel
to document it and its plugins.I expect the first PR build to fail. It's an old branch from before #48 and there are some things I need to fixup anyway.