Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coretasks: no realname for new JOINs on away-notify servers #2387

Closed
dgw opened this issue Dec 29, 2022 · 0 comments · Fixed by #2396
Closed

coretasks: no realname for new JOINs on away-notify servers #2387

dgw opened this issue Dec 29, 2022 · 0 comments · Fixed by #2396
Assignees
Labels
Bug Things to squish; generally used for issues
Milestone

Comments

@dgw
Copy link
Member

dgw commented Dec 29, 2022

As far as I can tell, the only place the realname of a newly joined user might be fetched is in the periodic WHO requests Sopel sends, which are currently skipped if the server supports away-notify:

sopel/sopel/coretasks.py

Lines 806 to 808 in 9965cce

if 'away-notify' in bot.enabled_capabilities:
# WHO not needed to update 'away' status
return

My half-baked ideas for this (not a ton of free time to think/research today) are:

  • Skip the above check and always _send_who() for channels periodically
  • Immediately WHO the exact nick after a user JOINs a channel and hasn't been seen before

I will edit the list if I come up with more ideas when actually working on this.

Follow-up to: #2383

@dgw dgw added the Bug Things to squish; generally used for issues label Dec 29, 2022
@dgw dgw added this to the 8.0.0 milestone Dec 29, 2022
@dgw dgw self-assigned this Dec 29, 2022
@dgw dgw closed this as completed in #2396 Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Things to squish; generally used for issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant