Track User's realname
#2383
Merged
Track User's realname
#2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested live on Rizon (no WHOX, uses 352 RPL_WHOREPLY format) and Libera (has WHOX, uses 354 RPL_WHOSPCRPL format). Need to extend the test suite to cover this stuff at some point.
Exirel
approved these changes
Dec 4, 2022
dgw
added a commit
that referenced
this pull request
Dec 29, 2022
Both I and the reviewer missed a bug in #2383 that passed arguments to `str.join()` wrong. Switched to `str.format()` at another maintainer's suggestion. Co-authored-by: SnoopJ <snoopjedi@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I saw a very angry person talking about Sopel somewhere (intentionally vague). Their complaint du jour was that Sopel doesn't expose
Users' realnames.While I chose not to engage them in conversation (some users, you're better off without, as goes the conventional business wisdom), the gap in our API is a valid point and it's not difficult to fix.
Checklist
make qa(runsmake qualityandmake test)sopel-ipythonconsole) that realnames were correctly populated from both WHO (on Rizon) and WHOX (on Libera) repliesNotes
I needed to get back to something else and didn't have time to work on tests right now, but still wanted to get the code itself out there for y'all wonderful people to look at. It'd be entirely valid to refuse approval until the test suite covers these functions, and I'd absolutely not take it personally. 😉