Use unicode strings to avoid UnicodeEncodeError #1040
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request. I can't merge it because I've already merged a different pull request which fixed this issue ( #1028 ). Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL module chokes when looking up the title of web pages that include unicode with the following error:
UnicodeEncodeError: 'ascii' codec can't encode character u'\xb7' in position 403: ordinal not in range(128) (file "/opt/willie/venv/lib/python2.7/site-packages/sopel/modules/url.py", line 191, in find_title)
(have it look up sopel-irc/sopel-extras#78 for an example)
Avoid this issue by handling strings as unicode.