fix weather.py to work with new Yahoo API changes #1058
Conversation
|
This is good but it is still using XML parsing - with the |
|
@maxpowa I'm still a bit new to git. Should a change like that get its own pull request or should I commit to this branch? |
|
|
|
@maxpowa What errors are you receiving? I've been running this updated module since I opened my pull request without issue. |
| uzip = first_result.get('postal').get('#text') or '' | ||
| bot.reply('I now have you at WOEID %s (%s%s, %s, %s %s)' % | ||
| (woeid, neighborhood, city, state, country, uzip)) | ||
| # uzip = first_result.get('postal').get('#text') or '' |
There was a problem hiding this comment.
This whole section, from here to the end of the diff, is messy. The commented-out code should simply be removed.
|
@dgw I removed the messy code |
|
👍 though I suspect that these commits should all be squashed into one before merging. |
| @@ -178,6 +178,5 @@ def update_woeid(bot, trigger): | |||
| city = first_result.get('name') | |||
| state = first_result.get('admin1').get('#text') or '' | |||
| country = first_result.get('country').get('#text') or '' | |||
| uzip = first_result.get('postal').get('#text') or '' | |||
There was a problem hiding this comment.
Yahoo's new API doesn't always return a zip code
|
@dgw I squashed the commits. It's much cleaner now. |
|
👍 @yoosi |
this closes #1050 and closes #1029
Yahoo no longer provides RSS feeds for weather.
bot now uses their most current API instead.