-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move etymology lookup to wiktionary #1178
Conversation
This actually accomplishes nothing, because the returned etymology from |
Built a proof-of-concept replacement The The Coveralls check failure for -0.9% test coverage tells me that my rewrite should also add example tests to this module. 12% coverage is downright awful. (The large drop must be from removing (Future implementation notes)Good words for testing this future rewrite include "sake" and "forte". As of writing this comment, both include two separate senses with independent etymologies and their own sets of definitions. (Edit: TIL you can't use Markdown inside <details> blocks… Thanks, GitHub.) |
These are at the mercy of Wiktionary editors changing the page content, but it doesn't look like the entry for "bailiwick" is edited much.
Shelving this until 7.1, unless |
I have no idea why I left this as WIP. It clearly works:
The main difference is obviously how detailed the etymologies are, but I think Wiktionary is a better bet over the long term. WT's editors will continue to flesh it out over time. I have a conflicts-resolved merge already done locally (it's not that bad) for testing, so don't worry about GitHub showing that this isn't mergeable @ reviewers. |
This spelling error prevents etymology lines from matching, because the code sets the
mode
toetymology
but then later looks for amode
equal toetmyology
. Fixed.