Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated gist API in help #1257

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Replace deprecated gist API in help #1257

merged 1 commit into from
Mar 27, 2018

Conversation

hekel
Copy link
Contributor

@hekel hekel commented Mar 20, 2018

Resolves #1254

@dgw
Copy link
Member

dgw commented Mar 20, 2018

Just as a general comment, replacing gists with another service that supports HTTPS would be ideal. Something like https://ptpb.pw/ perhaps?

@dgw dgw changed the title use ix.io instead of depreciated gist sopel-irc/sopel/#1254 Use ix.io instead of deprecated gist Mar 20, 2018
@dgw dgw added the Bug Things to squish; generally used for issues label Mar 20, 2018
@kwaaak
Copy link
Contributor

kwaaak commented Mar 22, 2018

I like Hastebin (https://hastebin.com/about.md), a service with some ephemerality would be a good choice. Expiration in well under 24 hours should be more than enough.

Copy link

@anarcat anarcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally LGTM, although this could break again when/if ix.io fails in turn. shouldn't we find a better way to dump the command list? why not just dump the command list a line at a time like other bots? :)

@dgw
Copy link
Member

dgw commented Mar 23, 2018

@anarcat See #1080 for one reason why Sopel no longer simply dumps the command list en masse. That said, changing from Gist to another pastebin provider (ix.io is not final) is merely one part of the solution. Eventually the plan is to have a local HTML/text option that can be hosted from the server Sopel runs on, and perhaps also have an option to turn the "deluge of PMs" method back on if it's really wanted.

@anarcat
Copy link

anarcat commented Mar 24, 2018

hmm... yeah okay, that makes sense - thanks!

@dgw dgw changed the title Use ix.io instead of deprecated gist Replace deprecated gist API in help Mar 26, 2018
@dgw dgw added this to the 6.5.2 milestone Mar 26, 2018
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it (but I'll stop short of putting a ring on it, mostly because pythons don't have fingers).

@dgw
Copy link
Member

dgw commented Mar 27, 2018

@anarcat, want to take a second look before I merge this?

@anarcat
Copy link

anarcat commented Mar 27, 2018

LGTM.

@dgw dgw merged commit 7cde9a8 into sopel-irc:master Mar 27, 2018
@dgw dgw added Bugfix Generally, PRs that reference (and fix) one or more issue(s) and removed Bug Things to squish; generally used for issues labels Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s) High Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants