-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IPython requirement #1263
Fix IPython requirement #1263
Conversation
ipython 6.0+ requires python 3.3+
Looks good, though the That said, while this shouldn't hurt anything, I don't think it's actually necessary. Installing IPython with my local
|
Yeah, I'd realized after opening this that builds were still succeeding even without this explicit specification. Not sure, in that case, what's going on with the issue. There is no IPython requirement currently in requirements.txt, unless I'm blind. |
You're not blind, I'm just GitHubbing tired (which one should never do, but I do anyway on a regular basis). It's not there. Which is strange, because it's a runtime dependency, not a dev dependency. Maybe take this patch and put the requirement where it belongs, and remove it from dev-requirements? At some point it might be worth considering making niche stuff like IPython (both the requirement and the module, if possible) only install if specifically requested using the extra requirements feature of python (e.g. you'd need to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
IPython 6.0+ requires Python 3.3+, so only install that version if we're using Python 3.3+.
This fixes #1194.