Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py2 warning #1488

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Py2 warning #1488

merged 1 commit into from
Mar 22, 2019

Conversation

deathbybandaid
Copy link
Contributor

This will simply display a warning about py2.x EOL

It won't exit, but gives people most of a year to straighten out their python versions.

Not saying Sopel should/will drop py2.7 support Jan 1st 2020, but we shouldn't tie our hands with this either.

@dgw dgw added this to the 7.0.0 milestone Feb 15, 2019
@dgw dgw added the Tweak label Feb 15, 2019
@dgw
Copy link
Member

dgw commented Feb 15, 2019

I think this could be one commit, titled something like "Add warnings about py2 EOL".

For the record, Sopel 7 might not even come out much before Jan 1, 2020. I'll probably put this in anyway, but it could be worth putting the cutoff date in the warning text instead of just saying "is near end of life".

Actually, we could probably just say outright that Sopel 8 is unlikely to still support Python 2. There's no way 8.0.0 will be done before 2020 based on the current typical version lifecycle. What say you?

@deathbybandaid
Copy link
Contributor Author

At my count, there are 26 files that use sys.version_info to make stuff work between py versions

@dgw
Copy link
Member

dgw commented Feb 15, 2019

Finding the ones that use try/except to import modules that moved will be useful, too, but harder (because you can't just grep for version_info) 😆

@dgw
Copy link
Member

dgw commented Mar 4, 2019

@deathbybandaid I was thinking you were going to squash this down. Were you?

Co-Authored-By: dgw <dgw@technobabbl.es>
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased to move the changes in run_script.py into cli/run.py.

We could get fancier with the wording, but there's no need really.

@dgw dgw merged commit 3ac3e65 into sopel-irc:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants