-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remind: add support for date in .at command #1590
Conversation
Wouhouh, tests pass with Python 2.7! That was my main concern at this point, given the extensive test suite I ran with Python 3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some little things from going through the single commit unique to this (not pulled from the base branch in #1581). Very few little things, in fact, but an important class-design consideration did come up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to make this just a "Comment" review, but there actually are enough things I would like to change that it warrants making that official. It's really close, though! I think we can merge this tomorrow. 🤞
Uh oh... apparently I made a mistake: since you forced-push to that branch, I had merge conflict locally for some unknown reason, and I think I messed-up the squashing... :-/ |
After double check, I believe it's all good. Ready for a new (and hopefully last) round of review before merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now, and I hope it's not because I'm tired. 😹
Just one line note that can be addressed if @Exirel has time to do so before I merge this and agrees that it's worth doing.
With corrections from dgw Co-Authored-By: dgw <dgw@technobabbl.es>
Co-Authored-By: dgw <dgw@technobabbl.es>
@dgw done |
This PR is based on #1581, and it replaces PR #1162.
Also fix #1148.
It can replace PR #1581 if someone is brave enough to do the review of all the changes in one go.
I added an extensive test-suite to make sure the remind
.at
command works as intended.I made
.at
opinionated about how date are expressed, with these choices:-
,.
, or/
, and it must be the same between each partsEven with all the unit-tests I added, I spent a good one hour with a live Sopel instance, and everything went according to the specs.