Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Rework logging #1678

Merged
merged 17 commits into from
Oct 8, 2019
Merged

[core] Rework logging #1678

merged 17 commits into from
Oct 8, 2019

Commits on Oct 8, 2019

  1. logger: use dictConfig and logger for raw log

    @Exirel
    Exirel committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    f205f10 View commit details
    Browse the repository at this point in the history

  2. logger: deprecate sopel.logger.get_logger 

    It was a nice idea, having a shortcut to get a logger. However, logging
is a python built-in, a de-facto standard since ages, so let's use it
instead.

Beside, the docstring is bonkers. Do not use `get_logger(__name__)`!

Inside a python module `__name__` is its python dotted path. So for
example in `sopel.modules.ip`, using `get_logger(__name__)` would mean
using the logger `sopel.modules.sopel.modules.ip`... which is kind of
dumb.

For external plugins, it's best to provide a good "how to configure
logging for your plugin" instead of using a bad shortcut function that
doesn't do what you would expect.
    @Exirel
    Exirel committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    60ffeb5 View commit details
    Browse the repository at this point in the history

  3. core: use logging for bot.error and bot.handle_error

    @Exirel
    Exirel committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    a437c65 View commit details
    Browse the repository at this point in the history

  4. core: stop redirecting output

    @Exirel
    Exirel committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    a3bedaf View commit details
    Browse the repository at this point in the history

  5. core: replace stderr by logging when possible

    @Exirel
    Exirel committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    f277164 View commit details
    Browse the repository at this point in the history

  6. ipython: no more swap stdout/stderr

    @Exirel
    Exirel committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    e18681b View commit details
    Browse the repository at this point in the history

  7. tools: sopel.tools.stdout will be removed in Sopel 8.0

    @Exirel
    Exirel committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    97e2f8c View commit details
    Browse the repository at this point in the history

  8. core: default logging level to INFO, fix sopel-irc#1337

    @Exirel
    Exirel committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    ec26635 View commit details
    Browse the repository at this point in the history

  9. logging: format messages with colon when necessary 

    And also fix my English grammar, but it fits nicely with the theme of "fixing messages".

Co-Authored-By: dgw <dgw@technobabbl.es>
    @Exirel @dgw
    Exirel and dgw committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    9fd7abc View commit details
    Browse the repository at this point in the history

  10. cli: add a reason for deprecation of redirect_outputs

    @Exirel
    Exirel committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    da4b9ee View commit details
    Browse the repository at this point in the history

  11. bot: add logging around plugins setup/shutdown

    @Exirel
    Exirel committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    3f7e69d View commit details
    Browse the repository at this point in the history

  12. logger: add get_plugin_logger for external plugins

    @Exirel
    Exirel committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    8c7bc92 View commit details
    Browse the repository at this point in the history

  13. core: log MODE issue as DEBUG instead of INFO

    @Exirel
    Exirel committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    90299d3 View commit details
    Browse the repository at this point in the history

  14. logging: minor grammar fixes 

    As per usual... ;-)

Co-Authored-By: dgw <dgw@technobabbl.es>
    @Exirel @dgw
    Exirel and dgw committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    664813b View commit details
    Browse the repository at this point in the history

  15. logger: move get_logger into tools

    @Exirel
    Exirel committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    3eb872d View commit details
    Browse the repository at this point in the history

  16. logger: yet another grammar fix 

    Co-Authored-By: dgw <dgw@technobabbl.es>
    @Exirel @dgw
    Exirel and dgw authored Oct 8, 2019
    Configuration menu
    Copy the full SHA
    04fc212 View commit details
    Browse the repository at this point in the history

  17. cli: replace stderr by logging

    @Exirel
    Exirel committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    a2c2d20 View commit details
    Browse the repository at this point in the history