Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db: fix get_uri() to return the actual connection URI #1774

Merged
merged 1 commit into from
Dec 7, 2019
Merged

db: fix get_uri() to return the actual connection URI #1774

merged 1 commit into from
Dec 7, 2019

Conversation

dgw
Copy link
Member

@dgw dgw commented Dec 6, 2019

We can tweak the docstrings and/or attribute names for consistency later. The point is, the function should now work fine no matter the db_type.

Closes #1745.

@dgw
db: fix get_uri() to return the actual connection URI
4ee6dfd 
We can tweak the docstrings and/or attribute names for consistency
later. The point is, the function should now work fine no matter
the `db_type`.
@dgw dgw added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label Dec 6, 2019
@dgw dgw added this to the 7.0.0 milestone Dec 6, 2019
@dgw dgw requested a review from a team December 6, 2019 05:11
RustyBower
RustyBower approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@RustyBower RustyBower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly what I was gonna do :)

@dgw dgw merged commit b024bf3 into master Dec 7, 2019
@dgw dgw deleted the fix-db.get_uri branch December 7, 2019 22:54
@dgw dgw mentioned this pull request Dec 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RustyBower RustyBower RustyBower approved these changes

Assignees
No one assigned
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s) Medium Priority
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

db: get_uri() assumes SQLite
2 participants
@dgw @RustyBower