Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

safety: properly check whether cache is too big #1802

Merged
merged 1 commit into from
Jan 14, 2020
Merged

safety: properly check whether cache is too big #1802

merged 1 commit into from
Jan 14, 2020

Conversation

r4f4
Copy link
Contributor

@r4f4 r4f4 commented Jan 14, 2020

This fixes the following error when sopel tries to clean up the
safety_cache:

ERROR - Unexpected error (unsupported operand type(s) for -: 'SopelMemory' and 'int')

Signed-off-by: Rafael Fonseca r4f4rfs@gmail.com

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@r4f4
safety: properly check whether cache is too big
bd46e7c 
This fixes the following error when sopel tries to clean up the
`safety_cache`:

ERROR    - Unexpected error (unsupported operand type(s) for -: 'SopelMemory' and 'int')

Signed-off-by: Rafael Fonseca <r4f4rfs@gmail.com>
@Exirel Exirel added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label Jan 14, 2020
@Exirel Exirel added this to the 7.0.0 milestone Jan 14, 2020
Exirel
Exirel approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, and well done!

dgw
dgw approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🙌🙌

@dgw dgw merged commit 370215d into sopel-irc:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

@dgw dgw dgw approved these changes

Assignees
No one assigned
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@r4f4 @dgw @Exirel