Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

units: fix mass when given exactly 1 pound #1829

Merged
merged 1 commit into from
Apr 5, 2020
Merged

units: fix mass when given exactly 1 pound #1829

merged 1 commit into from
Apr 5, 2020

Conversation

dgw
Copy link
Member

@dgw dgw commented Apr 2, 2020

Reported on IRC by sukil.

Description

Before:

<dgw> .mass 16 oz
<Sopel> dgw: 453.60g = 0.00 oz
<dgw> .mass 17 oz
<Sopel> dgw: 481.95g = 1.00 oz

After:

<dgw> .mass 16oz
<SopelTest> dgw: 453.60g = 1 pound
<dgw> .mass 17oz
<SopelTest> dgw: 481.95g = 1 pound 1.00 ounces

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
    • Relying on Travis for this. My local make quality reports a ton of errors because I'm in the middle of adding another style-checking plugin. 😁
  • I have tested the functionality of the things this change touches

@dgw dgw added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label Apr 2, 2020
@dgw dgw added this to the 7.0.1 milestone Apr 2, 2020
@dgw dgw requested a review from a team April 2, 2020 15:08
@dgw dgw changed the title units: fix mass when given exactly 1 pound / 16 ounces units: fix mass when given exactly 1 pound Apr 2, 2020
@dgw dgw merged commit 48f375e into master Apr 5, 2020
@dgw dgw deleted the units-fix-mass-pounds branch April 5, 2020 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Milestone
7.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@dgw @Exirel