Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loader: make sure URL callbacks are ready to pass through bot.call() #1855

Merged
merged 1 commit into from
May 1, 2020
Merged

loader: make sure URL callbacks are ready to pass through bot.call() #1855

merged 1 commit into from
May 1, 2020

Conversation

dgw
Copy link
Member

@dgw dgw commented May 1, 2020

Description

Non-admins hit an AttributeError on URL callbacks: 'function' object has no attribute 'unblockable'. The loader wasn't passing them through clean_callable to apply default attributes during clean_module.

This could be done without a new "limitable" category (just let URL callbacks live under the "triggerable" umbrella), but... it's more fun to micro-optimize memory usage for no reason.

Also: Fixed a stray assertion in loader tests that was checking a variable's identity property instead of equality.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw
loader: make sure URL callbacks are ready to pass through bot.call()
9646814 
This could be done without a new "limitable" category (just let URL
callbacks live under the "triggerable" umbrella), but... it's more fun
to micro-optimize memory usage for no reason.

Also: Fixed a stray assertion in loader tests that was checking a
variable's identity property instead of equality.
@dgw dgw added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label May 1, 2020
@dgw dgw added this to the 7.0.3 milestone May 1, 2020
@dgw dgw requested a review from a team May 1, 2020 08:10
Exirel
Exirel approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea. Love it.

@dgw dgw merged commit dbd9857 into 7.0.x May 1, 2020
@dgw dgw deleted the more-url-callback-fixes branch May 1, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Milestone
7.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@dgw @Exirel