bot: signal handler now checks if the bot is connected #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exirel
added
the
Bugfix
RhinosF1
reviewed
Jun 17, 2020
|
Thanks! |
dgw
requested changes
Jun 18, 2020
There was a problem hiding this comment.
Really trivial stuff here. Mostly, I'd just like for this to be rebased now that #1890 is merged, and see the fix: 🇫🇷 commit squashed out (even though it is hilarious). 😄
New logging: Yay! I swear there were comments somewhere explaining why the different signals were chosen, but maybe that was in the code that generates them.
Just marking "Request changes" so it's obvious in the PR list that I reviewed this but it's pending rebase.
Exirel
force-pushed
the
signals-on-connect
branch
from
b2d6853 to
40eb807
Compare
|
@dgw rebased & squashed! |
dgw
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1705
Description
(based on #1890)
I moved the signal handler to
sopel.bot.Sopel, and made sure that it sends QUIT message only if the bot is connected. When the bot is not connected, it raisesKeyboardInterruptinstead, which is properly handled (hopefully).Checklist
make qa(runsmake qualityandmake test)