Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rules, emoticons: action commands & commands working together at last #1894

Merged
merged 2 commits into from
Jun 24, 2020
Merged

rules, emoticons: action commands & commands working together at last #1894

merged 2 commits into from
Jun 24, 2020

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented Jun 18, 2020 •
edited
Loading

Description

All I wanted was to do /me flips table and have the bot to reply to me with the best emote ever.

However, I forgot just one little detail in my last PR about rules & commands, which is to not set the intents attribute in action_commands. Everything else was done and ready to work as intended, it was just this dumb line I forgot.

Oh well, what one can do about it?

/me flips table
(╯°□°）╯︵ ┻━┻

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@Exirel Exirel added the Feature label Jun 18, 2020
@Exirel Exirel added this to the 7.1.0 milestone Jun 18, 2020
@Exirel Exirel changed the title Emoticons action commands emoticons: action commands & commands working together at last Jun 18, 2020
dgw
dgw reviewed Jun 18, 2020
View reviewed changes
Copy link
Member

@dgw dgw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*cough* checklist? 😛 my GitHub page was outdated, sigh

sopel/modules/emoticons.py Outdated Show resolved Hide resolved
sopel/modules/emoticons.py Outdated Show resolved Hide resolved
@dgw dgw changed the title emoticons: action commands & commands working together at last rules, emoticons: action commands & commands working together at last Jun 18, 2020
dgw
dgw reviewed Jun 23, 2020
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Exirel Double check applied suggestion for me and squash anything you'd like to 🚀

@Exirel Exirel force-pushed the emoticons-action-commands branch from 92a68a7 to a7ccf8f Compare June 23, 2020 09:29
@Exirel
Copy link
Contributor Author

Exirel commented Jun 23, 2020

Squashed & rebased.

dgw
dgw approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dgw dgw merged commit 2503c94 into sopel-irc:master Jun 24, 2020
@Exirel Exirel deleted the emoticons-action-commands branch May 1, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Exirel @dgw