Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emoticons: add smirk command + action command #1899

Merged
merged 1 commit into from
Jul 1, 2020
Merged

emoticons: add smirk command + action command #1899

merged 1 commit into from
Jul 1, 2020

Conversation

dgw
Copy link
Member

@dgw dgw commented Jun 27, 2020

Description

Tin. Adds (¬‿¬) as a "smirk" emote.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw dgw added the Feature label Jun 27, 2020
@dgw dgw added this to the 7.1.0 milestone Jun 27, 2020
@dgw dgw requested a review from a team June 27, 2020 22:02
RustyBower
RustyBower approved these changes Jun 27, 2020
View reviewed changes
Copy link
Contributor

@RustyBower RustyBower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Exirel
Exirel approved these changes Jun 27, 2020
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I DISAGREE WITH EVERYTHING THAT IS IN THIS PR.

(¬‿¬)

@dgw dgw merged commit 64b8cdf into master Jul 1, 2020
@dgw dgw deleted the emoticons-add-smirk branch July 1, 2020 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RustyBower RustyBower RustyBower approved these changes

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dgw @Exirel @RustyBower