Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adminchannel: use TOPICLEN token from ISUPPORT if available #1956

Merged
merged 2 commits into from
Nov 30, 2020
Merged

adminchannel: use TOPICLEN token from ISUPPORT if available #1956

merged 2 commits into from
Nov 30, 2020

Conversation

dgw
Copy link
Member

@dgw dgw commented Oct 3, 2020

Description

Check the formatted topic against the IRC server's TOPICLEN, if sent, and present an error to the user if the topic is too long.

Bonus import cleanup and grammar fix, because I can't resist such things.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

Notes

Maybe talking about "bytes" is too technical—but the alternative is trying to give a mini-explainer about character encodings… It's probably fine?

@dgw dgw added the Feature label Oct 3, 2020
@dgw dgw added this to the 7.1.0 milestone Oct 3, 2020
@dgw dgw requested a review from a team October 3, 2020 18:31
Exirel
Exirel approved these changes Oct 4, 2020
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nice. 👍

@dgw dgw merged commit 9c8ce47 into master Nov 30, 2020
@dgw dgw deleted the adminchannel-use-topiclen branch November 30, 2020 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dgw @Exirel