adminchannel: allow non-op .topic in -t channels #1981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
half-duplex
added
Low Priority
Bugfix
4 tasks
dgw
approved these changes
Dec 25, 2020
There was a problem hiding this comment.
Awaiting rebase of parent PR #1980. I could see adding an event listener for 482 ERR_CHANOPRIVSNEEDED in case of race conditions or non-standard IRCd implementations, but doesn't have to be in this PR. It might be complicated, since 482 is a generic error reply, not specific to TOPIC commands.
half-duplex
force-pushed
the
topic-mode
branch
3 times, most recently
from
82bec94 to
1fde7d1
Compare
|
@half-duplex To conserve Travis build minutes, please hold off on updating/rebasing this PR until #1980 is merged. |
half-duplex
force-pushed
the
topic-mode
branch
from
1fde7d1 to
9c9aa2e
Compare
Depends on sopel-irc#1980. Fixes sopel-irc#1842.
half-duplex
force-pushed
the
topic-mode
branch
from
9c9aa2e to
9c324e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow
.topicfor all users in channels without+tset.Keeps topic mask related things op-only.
Depends on #1980. Improved with #1982. Fixes #1842.
Checklist
make qa(runsmake qualityandmake test)