Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reddit: fix floating point issue on % #1987

Merged
merged 1 commit into from
Dec 29, 2020
Merged

reddit: fix floating point issue on % #1987

merged 1 commit into from
Dec 29, 2020

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented Nov 9, 2020

Description

Fix #1884

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@Exirel Exirel added Low Priority Bugfix Generally, PRs that reference (and fix) one or more issue(s) labels Nov 9, 2020
@Exirel Exirel added this to the 7.1.0 milestone Nov 9, 2020
cottongin
cottongin reviewed Nov 9, 2020
View reviewed changes
@Exirel @cottongin
reddit: fix floating point issue on %
cc667c5 
Co-authored-by: cottongin <cottongin@users.noreply.github.com>
@Exirel Exirel force-pushed the reddit-floating-point-error branch from 104997d to cc667c5 Compare November 9, 2020 13:43
dgw
dgw approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bad that new contributor who was going to fix the issue disappeared, but hey. It's still fixed now.

@dgw dgw merged commit c02f52c into sopel-irc:master Dec 29, 2020
@Exirel Exirel deleted the reddit-floating-point-error branch May 1, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cottongin cottongin cottongin left review comments

@dgw dgw dgw approved these changes

Assignees
No one assigned
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s) Low Priority
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

reddit: floating point error in upvote ratio
3 participants
@Exirel @dgw @cottongin