tools.time: improve seconds_to_human #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
requested changes
Feb 7, 2021
There was a problem hiding this comment.
Just some nemesiS fighting in here. I'd like for the granularity parameter to round the value up if it's close to the next unit (e.g. 1h20m = "1 hour" but 1h40m = "2 hours"), but I don't even need to wait for you to say "let's do that in a future PR" because I already think that. x) I'll put that idea on the list for 8.0.
dgw
approved these changes
Feb 23, 2021
Co-authored-by: dgw <dgw@technobabbl.es>
Exirel
force-pushed
the
raw-seconds-to-human
branch
from
2e59ddc
to
7a9bc32
Compare
|
Squashed & rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #1824
Expose intermediate functions: one to split a time in seconds into a tuple of (years, months, days, hours, minutes, seconds) and the other that take that information to return a tuple of 2-value tuple with (value, unit).
Also, while I was working on making
second_to_humanmore reusable, I added agranularityparameter, because why not.Checklist
make qa(runsmake qualityandmake test)