-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pronouns: accept they/them and they/them/theirs #2070
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll keep things simple for 7.1 and take #2069. This can go in early 8.0, ideally right before the pronouns
plugin gets extracted into a standalone package.
This block is broken now that sopel/sopel/modules/pronouns.py Lines 61 to 64 in 2f05a7d
[2021-06-30 02:34:50,537] sopel.bot ERROR - Unexpected error ('list' object has no attribute 'items') from dgw at 2021-06-30 07:34:50.537146. Message was: ,pronouns dgw
Traceback (most recent call last):
File "/mnt/c/Users/dgw/github/sopel/sopel/bot.py", line 757, in call_rule
rule.execute(sopel, trigger)
File "/mnt/c/Users/dgw/github/sopel/sopel/plugins/rules.py", line 1057, in execute
exit_code = self._handler(bot, trigger)
File "/mnt/c/Users/dgw/github/sopel/sopel/modules/pronouns.py", line 76, in pronouns
say_pronouns(bot, trigger.group(3), pronouns)
File "/mnt/c/Users/dgw/github/sopel/sopel/modules/pronouns.py", line 91, in say_pronouns
for short, set_ in bot.memory['pronoun_sets'].items():
AttributeError: 'list' object has no attribute 'items' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just ship this with the conversion back to dict
I made. I'll continue tweaking things as I implement the new feature I was working on (based on this branch) when I discovered the .pronouns
-breaking regression.
Description
Checks:
Also fixes a typo ("eirslef").Closes#2068Furthers #2069
Checklist
make qa
(runsmake quality
andmake test
)