Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace (almost) all usage of sopel.module with sopel.plugin #2117

Merged
merged 2 commits into from
Jul 3, 2021

Conversation

dgw
Copy link
Member

@dgw dgw commented Jun 25, 2021

Description

Tin. coretasks and all tests (except test_module.py, for obvious reasons) now use the members of sopel.plugin only.

One more step on the road to #1738. This isn't actually part of the task list there, but it still feels good.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

Notes

Hopefully will not conflict with #2116, which already uses plugin for all its newly added decorator calls.

dgw added 2 commits June 25, 2021 01:18
Left `test_module.py` alone, of course. Everywhere else, mock plugin
file contents and test routines now use `plugin` exclusively.

Renamed one test to reflect the transitional state of its decorator
(`module.intent` -> `plugin.ctcp`) and the internal attributes not
having been renamed yet.
@dgw dgw added the Tweak label Jun 25, 2021
@dgw dgw added this to the 8.0.0 milestone Jun 25, 2021
@dgw dgw requested a review from a team June 25, 2021 06:48
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does feel good.

@dgw dgw merged commit 9f80f60 into master Jul 3, 2021
@dgw dgw deleted the de-module-things branch July 3, 2021 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants