bot: remove bot.memory['url_callbacks'] and use internal state
#2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plugins doing this will receive warnings through the entire remaining lifetime of 7.x (at least several months, perhaps up to a year or two), and it's high time to push plugin devs away from using anything but the `plugin.url` and `plugin.url_lazy` decorators. Sopel 9.0 will drop the `(un)register_url_callback` functions, finally ending the era of plugins manually managing their own URL callbacks.
Removed test checking that manually registered callbacks still work, and replaced it with one that makes sure they do NOT work any more.
dgw
added
Medium Priority
Tweak
Breaking Change
Exirel
reviewed
Jun 28, 2021
Missed the boat on being deprecated in 7.1, and semver principles say it will have to wait until 8.0 for "official" deprecation. It's fine. Nobody uses this stuff anyway. There's no reason to.
Exirel
approved these changes
Jun 28, 2021
SnoopJ
changed the title
bot.memory['url_callbacks] and use internal statebot.memory['url_callbacks'] and use internal state
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Plugins doing this will receive warnings through the entire remaining lifetime of 7.x (at least several months, perhaps up to a year-ish), and it's high time to push plugin devs away from using anything but the
plugin.urlandplugin.url_lazydecorators.As pointed out in a comment below, also deprecates
bot.search_url_callbacks()(which should have been deprecated along with its register/unregister siblings).Checklist
make qa(runsmake qualityandmake test)Notes
Sopel 9.0 will drop the
(un)register_url_callbackfunctions, finally ending the era of plugins manually managing their own URL callbacks. That will feel almost as good as dumping Python 2. 😁This could have been one commit, and I didn't test the intermediate state. Initially I was only going to remove the stuff that said it could be removed in 8.0, then remembered that there was more to that story.