Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conftest: remove hacks/shims for running tests on Python 3.3 #2123

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

dgw
Copy link
Member

@dgw dgw commented Jun 28, 2021

Description

Tin. IIRC some of the behavior I'm removing was to work around issues that were only reproducible under Python 3.3 on Travis CI (and not in my local 3.3 env), making them doubly irrelevant now that we switched to GitHub Actions and only support py3.6+.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw dgw added this to the 8.0.0 milestone Jun 28, 2021
@dgw dgw requested a review from a team June 28, 2021 03:29
@dgw dgw mentioned this pull request Jun 28, 2021
3 tasks
@dgw dgw added the Housekeeping Code cleanup, removal of deprecated stuff, etc. label Jul 5, 2021
@dgw dgw merged commit 86cbbe4 into master Jul 6, 2021
@dgw dgw deleted the conftest-deadsnakes branch July 6, 2021 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Housekeeping Code cleanup, removal of deprecated stuff, etc. Low Priority Tests Tweak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants