docs: clarify relationship between owner and owner_account (again)
#2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were going to make `core.owner` optional in Sopel 8, but that's not wise. The setting is used to send important notices to the bot's owner, and so it has to be set with a proper value even if `core.owner_account` is being used for verification (e.g. `plugin.require_owner`).
Exirel
requested changes
Jun 28, 2021
Our `ConfigParser` invokation does not allow inline comments, so users could copy and paste broken snippets with comments as part of the value. Regardless of whether it's a good idea to enable inline comment support for Sopel 8, we need clean documentation for the 7.1.x stable branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were going to make
core.owneroptional in Sopel 8, but that's not wise. The setting is used to send important notices to the bot's owner, and so it has to be set with a proper value even ifcore.owner_accountis being used for verification (e.g.plugin.require_owner).Checklist
make qa(runsmake qualityandmake test)Notes
Can be merged with a
[skip ci], as it only touches docs.Should be cherry-picked back to 7.1.x with a
[skip ci]so as not to burn Travis credits.