loader: drop compatibility code for old-style Phenny/Jenni modules #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Way back, before the `plugin` (or `module`) decorators were a thing, "modules" of the time were written by directly assigning attributes of each callable to add the required properties for the bot's loader. We don't support that any more. Code like that is probably five or more years old *at minimum*, and should be updated. Also drops related tests, of course.
dgw
added
Low Priority
Tweak
Tests
Breaking Change
Exirel
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Way back, before the
plugin(ormodule) decorators were a thing, "modules" of the time were written by directly assigning attributes of each callable to add the required properties for the bot's loader.We don't support that any more. Code like that is probably five or more years old at minimum, and should be updated.
Also drops related tests, of course.
Checklist
make qa(runsmake qualityandmake test)Notes
Did I think about raising some kind of warning instead of silently correcting the values as Sopel 7.x and earlier have been doing? Yes. I decided against it, because that would just replace one kind of legacy fallback mode with another. Rip off the band-aid.