Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

irc: MyInfo namedtuple with proper type hint #2134

Merged
merged 2 commits into from
Aug 2, 2021
Merged

irc: MyInfo namedtuple with proper type hint #2134

merged 2 commits into from
Aug 2, 2021

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented Jul 2, 2021

Description

Tin.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@Exirel Exirel added this to the 8.0.0 milestone Jul 2, 2021
@Exirel Exirel requested a review from a team July 2, 2021 12:39
@dgw
Copy link
Member

dgw commented Jul 5, 2021

Why not delete MYINFO_ARGS too? I can't find any references to it except in the removed function call.

sopel/sopel/irc/utils.py

Line 13 in 41c6ce4

MYINFO_ARGS = ['client', 'servername', 'version']

@Exirel
Copy link
Contributor Author

Exirel commented Jul 5, 2021

Why not delete MYINFO_ARGS too?

I forgot about it, putain.

dgw
dgw approved these changes Jul 5, 2021
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean code is happy code? Maybe.

@Exirel Exirel force-pushed the irc-utils-myinfo-namedtuple branch from f072efb to 6b63eb2 Compare July 5, 2021 06:53
@dgw dgw merged commit e607f08 into sopel-irc:master Aug 2, 2021
@Exirel Exirel deleted the irc-utils-myinfo-namedtuple branch December 31, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

Assignees
No one assigned
Labels
Low Priority Tweak
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Exirel @dgw