cli.plugins: keep plugin meta info on loading error #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exirel
added
the
Bugfix
dgw
approved these changes
Jul 5, 2021
There was a problem hiding this comment.
I tested it, and 👍.
dgw@Lamarr:~/github/sopel$ sopel-plugins list
[...snip...]
broken/python-file broken plugin (error: invalid syntax (broken.py, line 9)) (/home/dgw/.sopel/plugins/broken.py) [error]
[...snip...]
dgw@Lamarr:~/github/sopel$ sopel-plugins show broken
Plugin: broken
Status: error
Type: python-file
Source: /home/dgw/.sopel/plugins/broken.py
Label: broken plugin (error: invalid syntax (broken.py, line 9))
Loading failed
Exirel
force-pushed
the
cli-plugins-list-show-error-info
branch
from
e401c86
to
4df1d0e
Compare
dgw
added a commit
that referenced
this pull request
Aug 4, 2021
cli.plugins: keep plugin meta info on loading error Backported from master.
|
The answer is, yes, this can be applied to 7.1.x. And so we shall, because this is a silly bug. |
dgw
added a commit
that referenced
this pull request
Aug 5, 2021
cli.plugins: keep plugin meta info on loading error Backported from master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #2113
Checklist
make qa(runsmake qualityandmake test)