Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invite: handle expected possible exception #2151

Merged
merged 1 commit into from
Jul 6, 2021
Merged

invite: handle expected possible exception #2151

merged 1 commit into from
Jul 6, 2021

Conversation

dgw
Copy link
Member

@dgw dgw commented Jul 5, 2021

Description

Avoids "Unknown error" output to IRC and exception traceback log dump.

Before:

<grym> .invite hasn't been doing what i need >.> 
<Sopel> Unexpected error (Target channel name must not be a nick.) from grym at 2021-07-05
         15:49:16.901922. Message was: .invite hasn't been doing what i need >.>

After:

<dgw> .invite hasn't been doing what i need >.>
<SopelTest> dgw: Target channel name must not be a nick.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw
invite: handle expected possible exception
a61afe9 
Avoids "Unknown error" output to IRC and exception traceback log dump.
@dgw dgw added Low Priority Bugfix Generally, PRs that reference (and fix) one or more issue(s) labels Jul 5, 2021
@dgw dgw added this to the 7.1.2 milestone Jul 5, 2021
@dgw dgw requested a review from a team July 5, 2021 18:32
@dgw dgw merged commit 8f38990 into master Jul 6, 2021
@dgw dgw deleted the invite-catch-exception branch July 6, 2021 05:54
dgw added a commit that referenced this pull request Jul 6, 2021
@dgw
invite: handle expected possible exception [skip ci]
7a52c9c 
Avoids "Unknown error" output to IRC and exception traceback log dump.

Backport of #2151 for 7.1.x maintenance branch. CI skipped as the change
does not touch testable code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s) Low Priority
Projects
None yet
Milestone
7.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@dgw @Exirel