translate: handle failure/error better in .mangle
#2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
added
the
Bugfix
dgw
added a commit
that referenced
this pull request
Aug 6, 2021
translate: handle failure/error better in `.mangle` Cherry-picked from master: 3d07382
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should resolve #2021 by outputting a friendly error instead of what has become an "Unexpected error" involving concatenating
NoneTypetostrthanks to the output-prefix consistency pass we did in 7.1.Checklist
make qa(runsmake qualityandmake test)Notes
The logic in this plugin could do with a refactor, especially making
translate()raise an exception instead of returning garbage. But I'm not up for that tonight, and it wouldn't be appropriate to do that for a 7.1.x bugfix release anyway.