Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reddit: don't anchor to end of post links #2163

Merged
merged 1 commit into from
Aug 8, 2021
Merged

reddit: don't anchor to end of post links #2163

merged 1 commit into from
Aug 8, 2021

Conversation

dgw
Copy link
Member

@dgw dgw commented Jul 18, 2021

Description

Including the $ end-of-string anchor means that the plugin won't get triggered for reddit post URLs that include ?sort=new etc. First of all, they should be included. Second, and more importantly, comment links work regardless of query parameters.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw
reddit: don't anchor to end of post links
cd10576 
Including the `$` end-of-string anchor means that the plugin won't get
triggered for reddit post URLs that include `?sort=new` etc.

First of all, they should be included. Second, and more importantly,
comment links work regardless of query parameters being present.
@dgw dgw added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label Jul 18, 2021
@dgw dgw added this to the 7.1.3 milestone Jul 18, 2021
@dgw dgw requested a review from a team July 18, 2021 05:30
@dgw dgw merged commit aac60ea into master Aug 8, 2021
@dgw dgw deleted the reddit-post-link-query branch August 8, 2021 07:08
dgw added a commit that referenced this pull request Aug 8, 2021
@dgw
Merge pull request #2163 from sopel-irc/reddit-post-link-query
0f88641 
reddit: don't anchor to end of post links

Cherry-picked from master: aac60ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Milestone
7.1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@dgw @Exirel