coretasks: correctly abort SASL PLAIN on invalid server reply #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally flagged as an unused local variable by LGTM, but turned out to be a real bug.
Exirel
approved these changes
Oct 1, 2021
|
This could be backported to a 7.1.5. 😁 |
|
The code for 7.1.x is actually quite different, as proved by Git failing to apply this patch on top of it (merge conflict). I'll have to go through the older code paths and see if the same bug is there. |
dgw
added a commit
that referenced
this pull request
Oct 5, 2021
tl;dr: If the server sends something unrecognized, the correct behavior is to abort authentication explicitly rather than silently ignoring it.
This was referenced Oct 5, 2021
dgw
added a commit
that referenced
this pull request
Oct 8, 2021
tl;dr: If the server sends something unrecognized, the correct behavior is to abort authentication explicitly rather than silently ignoring it.
dgw
added a commit
that referenced
this pull request
Oct 11, 2021
coretasks: backport SASL abort from #2187 Can [skip ci] to save the build credits; PR+HEAD already tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Originally flagged as an unused local variable by LGTM, but turned out to be a real bug.
Could be worth cutting a 7.1.5 release.No, that code is different and this patch doesn't apply.Checklist
make qa(runsmake qualityandmake test)